Skip to content

Commit

Permalink
ref(replay/feedback): don't suggest empty tag
Browse files Browse the repository at this point in the history
  • Loading branch information
michellewzhang committed Nov 6, 2024
1 parent e9d3c7f commit 3afff38
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
7 changes: 6 additions & 1 deletion static/app/components/feedback/feedbackSearch.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,12 @@ export default function FeedbackSearch() {
projectIds: projectIds?.map(String),
endpointParams,
}).then(
tagValues => (tagValues as TagValue[]).map(({value}) => value),
tagValues =>
(tagValues as TagValue[])
.filter(tagValue => {
return tagValue.name !== '';
})
.map(({value}) => value),
() => {
throw new Error('Unable to fetch event field values');
}
Expand Down
5 changes: 4 additions & 1 deletion static/app/views/replays/list/replaySearchBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,10 @@ function ReplaySearchBar(props: Props) {
endpointParams,
includeReplays: true,
}).then(
tagValues => (tagValues as TagValue[]).map(({value}) => value),
tagValues =>
(tagValues as TagValue[])
.filter(tagValue => tagValue.name !== '')
.map(({value}) => value),
() => {
throw new Error('Unable to fetch event field values');
}
Expand Down

0 comments on commit 3afff38

Please sign in to comment.