Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the case when query runner configuration is an empty dict #7258

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

arikfr
Copy link
Member

@arikfr arikfr commented Dec 20, 2024

What type of PR is this?

  • Bug Fix

Description

The migration introduced in #7184 creates query runners with an empty configuration dictionary. Some query runners raise an exception if the configuration dictionary doesn't contain some keys. This PR updates the implementation to use get instead of direct access.

Fixes #7221.

How is this tested?

  • Manually

Copy link
Collaborator

@eradman eradman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@eradman eradman merged commit 89d7f54 into master Dec 24, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Recent ReHash db Migration throw an Error
2 participants