Support result reuse in Athena data sources #7202
Open
+65
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtaniwaki
commented
Oct 23, 2024
| @@ -116,7 +116,7 @@ pandas = "1.3.4" | |||
| phoenixdb = "0.7" | |||
| pinotdb = ">=0.4.5" | |||
| protobuf = "3.20.2" | |||
| pyathena = ">=1.5.0,<=1.11.5" | |||
| pyathena = "2.25.2" | |||
There was a problem hiding this comment.
pyathena 3.x requires python >= 3.8.1, which conflicts with python >= 3.8 of the redash requirements, so I decided to use 2.x.
dtaniwaki
changed the title
|
@lucydodo @justinclift Could you consider merging this feature? |
|
It looks good, but since the version of the |
|
@lucydodo What else can I do to get this reviewed and merged? |
|
Sorry, I've been busy for a while and haven't had time to review it. I'll review and respond this weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Currently, redash makes a query everytime the query page opens and it costs a lot if the query is too heavy.
On the other hand, there is a feature that efficiently uses query results in Athena.
https://docs.aws.amazon.com/athena/latest/ug/reusing-query-results.html
pyathena (>=2.18.0) supports the option.
https://github.com/laughingman7743/PyAthena/blob/6b8f0e94abd09115ba1277616ca84372e2f15d56/pyathena/common.py#L112-L113
It seems the reason of updating the major version is dropping python versions. and as far as I tried, queries work fine.
We may want to turn on/off the option per query but it will break the compatibility with the other data sources, so I made it a data source option. Could you consider adding this feature?
How is this tested?
Run an Athena query with this option with manually container image.
Related Tickets & Documents
N/A
Mobile & Desktop Screenshots/Recordings (if there are UI changes)