Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically use the latest version of PostgreSQL #6851

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

justinclift
Copy link
Member

What type of PR is this?

  • Other

Description

Instead of keeping PostgreSQL pinned to a specific version, which we need to manually update over time, lets just use the latest version.

This should have no negative impact on us, and the pgautoupgrade repository already automatically upgrades between PostgreSQL versions anyway.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)

This PR passes all of our unit tests and Cypress tests when run on my local system.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.82%. Comparing base (4eb5f4e) to head (530151e).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6851   +/-   ##
=======================================
  Coverage   63.82%   63.82%           
=======================================
  Files         161      161           
  Lines       13060    13060           
  Branches     1803     1803           
=======================================
  Hits         8335     8335           
  Misses       4425     4425           
  Partials      300      300           

Copy link
Collaborator

@eradman eradman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to make this change to .ci/compose.ci.yaml and .ci/compose.cypress.yaml?

@justinclift
Copy link
Member Author

justinclift commented Apr 5, 2024

Thanks, totally forgot about those. I'll update the PR to include them as well. 😄

@justinclift justinclift enabled auto-merge (squash) April 5, 2024 14:36
@justinclift
Copy link
Member Author

k, those two have been updated and added to this PR as well.

There don't seem to be any further missed compose files using PostgreSQL, so I think this PR is good now. 😄

Copy link
Collaborator

@eradman eradman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we run into a problem with using PG latest it will most likely be because of a bug in SQLAlchemy. Looks good

@justinclift justinclift merged commit 15e6583 into master Apr 5, 2024
16 checks passed
@justinclift justinclift deleted the pgauto_latest_v1 branch April 5, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants