Node 18 #6752
Node 18 #6752
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6752 +/- ##
=======================================
Coverage 63.42% 63.42%
=======================================
Files 162 162
Lines 13173 13173
Branches 1819 1819
=======================================
Hits 8355 8355
Misses 4522 4522
Partials 296 296 |
AndrewChubatiuk
force-pushed
the
node-18
branch
3 times, most recently
from
4323826 to
58e2e5d
Compare
|
@justinclift @guidopetri could you please review it? |
|
@justinclift @guidopetri are you still maintaining a repo? |
|
@AndrewChubatiuk I'm taking some time off after hitting the early stages of burn out. 😦 |
| "analyze": "yarn clean && BUNDLE_ANALYZER=on webpack", | ||
| "analyze:build": "yarn clean && NODE_ENV=production BUNDLE_ANALYZER=on webpack", | ||
| "analyze": "yarn clean && BUNDLE_ANALYZER=on NODE_OPTIONS=--openssl-legacy-provider webpack", | ||
| "analyze:build": "yarn clean && NODE_ENV=production BUNDLE_ANALYZER=on NODE_OPTIONS=--openssl-legacy-provider webpack", |
There was a problem hiding this comment.
Sounds like this is needed for NodeJS 18 to work with the Redash repo then yeah?
There was a problem hiding this comment.
this is needed to work with machines with old version of openssl
Head branch was pushed to by a user without write access
AndrewChubatiuk
force-pushed
the
node-18
branch
from
3ba6813 to
568407c
Compare
|
Thanks for getting this done @AndrewChubatiuk. I'm going to be less active on GitHub for maybe a week or so, but feel free to ping me if something needs attention. 😄 |
|
@justinclift wanted to merge #6674. MR is failing, but this is because it's running scenarios from master |
|
@AndrewChubatiuk Interesting. That looks like it'll need some proper thinking about to fix, which I don't have the mental bandwidth for at the moment. 😦 Saying that because I'm under the impression it shouldn't be running scenarios from If that's what's really happening, then that sounds like a problem in itself. 😦 |
|
@AndrewChubatiuk can you update https://github.com/getredash/redash/wiki/Local-development-setup to match? I assume this change implies that we should be running |
|
Awesome. Thanks heaps @snickerjp. 😄 |
What type of PR is this?
Node 18 is not the latest stable, but at least still maintained in contrast to 16 and 14. Tested it with Node 20 as well, but currently there's no cypress image with node 20
Description
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)