Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed notification template #6721

Merged

Conversation

dvandonkelaar
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

This PR fixed non-rendered template for the Discord notification.

Old situation: "Alert threshold: {{ ALERT_THRESHOLD }}."
New situationL "Alert threshold: 1."

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

This issue is decribed in #6676

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

N.A.

@dvandonkelaar dvandonkelaar marked this pull request as draft January 20, 2024 09:14
Copy link

codecov bot commented Jan 22, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (97db492) 63.37% compared to head (5eabebb) 63.37%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6721   +/-   ##
=======================================
  Coverage   63.37%   63.37%           
=======================================
  Files         162      162           
  Lines       13170    13170           
  Branches     1819     1819           
=======================================
  Hits         8347     8347           
  Misses       4532     4532           
  Partials      291      291           
Files Coverage Δ
redash/destinations/discord.py 65.62% <50.00%> (ø)

@dvandonkelaar dvandonkelaar marked this pull request as ready for review January 22, 2024 05:31
Copy link
Contributor

@guidopetri guidopetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@guidopetri guidopetri merged commit d245ff7 into getredash:master Jan 30, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants