Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display catalog information on the schema pane when connecting to Trino #6578

Merged
merged 1 commit into from
Nov 7, 2023

Conversation

masayuki038
Copy link
Collaborator

@masayuki038 masayuki038 commented Nov 6, 2023

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

When connecting to Trino, if you specify Catalog, the name is not displayed on the left side of Redash's Query Editor. However, the query must be specified in the format catalog.schema.table (below).

image

Therefore, even if you connect to Trino with Catalog specified, it should display catalog.schema.table.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Closes #6574

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

image
image

@masayuki038 masayuki038 marked this pull request as ready for review November 6, 2023 15:54
@masayuki038
Copy link
Collaborator Author

@justinclift @guidopetri Could you review this? thank you.

Copy link
Contributor

@guidopetri guidopetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thanks so much @masayuki038 !

@guidopetri guidopetri merged commit 198b422 into master Nov 7, 2023
14 checks passed
@guidopetri guidopetri deleted the show_trino_category_on_schema_pane branch November 7, 2023 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display catalog information on the schema pane when connecting to Trino
2 participants