Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove "Datree" badge from README #6526

Merged
merged 1 commit into from
Oct 16, 2023
Merged

chore: Remove "Datree" badge from README #6526

merged 1 commit into from
Oct 16, 2023

Conversation

winebarrel
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Datree badge is broken and will be removed from the README.
cf. https://s3.amazonaws.com/catalog.static.datree.io/datree-badge-20px.svg

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

N/A

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Before:
スクリーンショット 2023-10-16 15 42 56

After:
スクリーンショット 2023-10-16 15 44 49

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #6526 (cd2921f) into master (6b98197) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6526   +/-   ##
=======================================
  Coverage   61.26%   61.26%           
=======================================
  Files         158      158           
  Lines       12889    12889           
  Branches     1755     1755           
=======================================
  Hits         7896     7896           
  Misses       4743     4743           
  Partials      250      250           

@justinclift
Copy link
Member

Interesting, thanks for this PR @winebarrel. 😄

Looking at the Datree repository on GitHub, it seems like their commercial product has been discontinued and the remains (a cli?) have become Open Source:

image

So yeah, seems like their badges aren't likely to be coming back any time soon. 😦

@justinclift justinclift enabled auto-merge (squash) October 16, 2023 07:08
Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 😄

@justinclift justinclift merged commit 12f1050 into getredash:master Oct 16, 2023
13 checks passed
@winebarrel winebarrel deleted the chore/remove_datree_badge branch October 16, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants