Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Debian image in Dockerfile #6524

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Update Debian image in Dockerfile #6524

merged 2 commits into from
Oct 16, 2023

Conversation

winebarrel
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Use the latest stable release "bookworm" as the Docker base image instead of "buster", which is already LTS.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

N/A

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #6524 (205ab52) into master (12f1050) will not change coverage.
The diff coverage is n/a.

❗ Current head 205ab52 differs from pull request most recent head f26dd5e. Consider uploading reports for the commit f26dd5e to get more accurate results

@@           Coverage Diff           @@
##           master    #6524   +/-   ##
=======================================
  Coverage   61.26%   61.26%           
=======================================
  Files         158      158           
  Lines       12889    12889           
  Branches     1755     1755           
=======================================
  Hits         7896     7896           
  Misses       4743     4743           
  Partials      250      250           

@justinclift
Copy link
Member

Good idea. Debian Buster's End of Life (EOL) is in about 8 months, whereas Debian Bookworm's EOL is in about 4 and a half years. 😄

Copy link
Member

@justinclift justinclift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concept is good. If this passes our CI tests, then lets merge this. 😄

@justinclift justinclift enabled auto-merge (squash) October 16, 2023 08:12
@justinclift justinclift merged commit 84d1693 into getredash:master Oct 16, 2023
11 checks passed
@winebarrel winebarrel deleted the update_debian_release branch October 16, 2023 09:38
@winebarrel
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants