Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display bigquery subfield of record as schema. #6522

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

fukatani
Copy link
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

We want to dIsplay field of RECORD type of BigQuery as schema.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

Screenshot from 2023-10-15 17-18-22

Scheme (BigQuery console)
Screenshot from 2023-10-15 17-28-11

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #6522 (09b9482) into master (4210808) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #6522   +/-   ##
=======================================
  Coverage   61.53%   61.53%           
=======================================
  Files         158      158           
  Lines       12898    12898           
  Branches     1756     1756           
=======================================
  Hits         7937     7937           
  Misses       4704     4704           
  Partials      257      257           
Files Coverage Δ
redash/query_runner/big_query.py 23.68% <0.00%> (ø)

Copy link
Contributor

@guidopetri guidopetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, I didn't know you could do this! Thank you @fukatani !

@guidopetri guidopetri enabled auto-merge (squash) October 17, 2023 02:54
@guidopetri guidopetri disabled auto-merge October 17, 2023 03:04
@guidopetri
Copy link
Contributor

This passed previously, so force-merging in

@guidopetri guidopetri merged commit ddbe0f6 into getredash:master Oct 17, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants