Single word title for Google Spreadsheet #6510
Conversation
immortalcodes
changed the title
There was a problem hiding this comment.
@immortalcodes thanks for the PR! I left a few comments - the refactor of this function isn't as straightforward as it looks. We should strive to simplify this function and make it more understandable.
|
Looks like this PR has a formatting problem that needs fixing:
|
|
I have used a delimiter to have string and title both as a string and still be able to differentiate between them |
|
I guess this might require changing the unit tests as well |
| @@ -100,18 +100,20 @@ def __init__(self, worksheet_title): | |||
| def parse_query(query): | |||
| values = query.split("|") | |||
| key = values[0] # key of the spreadsheet | |||
| worksheet_num_or_title = 0 # A default value for when a number of inputs is invalid | |||
| worksheet_pointer = ' 1' # A default value for when a number of inputs is invalid | |||
There was a problem hiding this comment.
@immortalcodes hey, thanks for updating this PR. I think I might have misspoken though, or I wasn't clear in my communication - we want to separate parse_query into two versions of a similar function, where one uses a worksheet number and the other uses the title, and we want to call the correct function depending on what the user inputs.
There was a problem hiding this comment.
Ideally, we don't have to worry about things like a space prefix on a string signifying anything; we should keep the data as separate as possible from the code logic.
|
@immortalcodes hey, just checking in. Any interest in finishing this PR still? |
Yup, was busy with some work |
What type of PR is this?
Description
This fixes and works on the issue #6409
The query_runner for google spreadsheet has now some refactoring and recognise single word title without quotes
How is this tested?
Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)