-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add column type to a query result of InfluxDB #6505
Conversation
@masayuki038 Thanks for this PR. 😄 It looks like it needs some adjustment to the formatting, in order to pass our CI checks:
|
Codecov Report
@@ Coverage Diff @@
## master #6505 +/- ##
==========================================
+ Coverage 61.10% 61.26% +0.15%
==========================================
Files 158 158
Lines 12883 12889 +6
Branches 1753 1755 +2
==========================================
+ Hits 7872 7896 +24
+ Misses 4765 4743 -22
- Partials 246 250 +4
|
@justinclift Thanks for your following up. I fixed the unused import issue and pushed the branch again. However, it failed...
Should I add .env to this branch ? |
Huh, that check should not have run. I'll take a look at it later. For now you can just ignore the failing check |
tests/query_runner/test_influx_db.py
Outdated
raw_no_rows = {"series": [{"name": "typetest", "columns": ["time", "k1", "v1", "v2"], "values": []}]} | ||
|
||
|
||
class TestTransformResult(TestCase): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind rewriting these as pytest
tests? We want to move our codebase away from unittest.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, thanks so much @masayuki038 ! I left one more comment but it's a nit. I'm good with merging if you don't want to change the names, but I'll wait until tomorrow to merge in case you do :)
tests/query_runner/test_influx_db.py
Outdated
raw_no_rows = {"series": [{"name": "typetest", "columns": ["time", "k1", "v1", "v2"], "values": []}]} | ||
|
||
|
||
def test_result(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: can we rename the tests to be more descriptive? Maybe something like test_influxdb_result_types_with_rows
and test_influxdb_result_types_with_no_rows_are_string
?
Thanks so much @masayuki038 ! |
What type of PR is this?
Description
Bug fix for #6179
I confirmed that it works fine to download these files (below) in a query page of Redash by manual test:
How is this tested?
Related Tickets & Documents
Closes #6179
Mobile & Desktop Screenshots/Recordings (if there are UI changes)