Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert docker-compose to docker compose #6504

Merged
merged 1 commit into from
Oct 8, 2023
Merged

Conversation

guidopetri
Copy link
Contributor

What type of PR is this?

  • Other

Description

Docker now has compose support within it, and installing the latest version of docker allows for docker compose. The old docker-compose syntax is being deprecated. This change moves us from the old docker-compose syntax to the new docker compose syntax.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Via PR checks.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #6504 (aad2d22) into master (0f175b7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #6504   +/-   ##
=======================================
  Coverage   61.10%   61.10%           
=======================================
  Files         158      158           
  Lines       12883    12883           
  Branches     1753     1753           
=======================================
  Hits         7872     7872           
  Misses       4765     4765           
  Partials      246      246           

@justinclift
Copy link
Member

What version of Docker are you using that works with this?

Asking so we have some idea of a known-good configuration. 😄

@guidopetri
Copy link
Contributor Author

I'm on docker 24. If you follow the current install instructions, it seems to just get the latest version: https://docs.docker.com/engine/install/debian/#install-using-the-repository

@guidopetri guidopetri force-pushed the gpetri/docker_compose branch from 3603391 to aad2d22 Compare October 8, 2023 01:11
@guidopetri guidopetri requested a review from justinclift October 8, 2023 01:20
@justinclift
Copy link
Member

From eyeballing the change, it looks fairly straight forward.

I've not personally used the v2 docker compose commands yet though, so no practical experience of potential gotchas we should watch out for.

I guess we can merge it, and if something goes badly wrong then we can revert the change (or fix whatever the problem is).

@justinclift justinclift merged commit 138339a into master Oct 8, 2023
16 checks passed
@justinclift justinclift deleted the gpetri/docker_compose branch October 8, 2023 02:06
@eradman
Copy link
Collaborator

eradman commented Oct 9, 2023

@guidopetri can youupdate the dev environment setup instructions to match this change?

https://github.com/getredash/redash/wiki/Local-development-setup#set-up-the-prerequisites

@guidopetri
Copy link
Contributor Author

Ah, yes! Good call.

@guidopetri
Copy link
Contributor Author

@eradman thanks again for updating those docs for me 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants