Fix dockerhub image building #6503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6503 +/- ##
==========================================
+ Coverage 61.08% 61.10% +0.02%
==========================================
Files 158 158
Lines 12878 12883 +5
Branches 1753 1753
==========================================
+ Hits 7866 7872 +6
+ Misses 4766 4765 -1
Partials 246 246
|
|
Double checked and the image builds + pushes to dockerhub 🎉 so I set up automerge. |
|
Fantastic! Good stuff @guidopetri! 😄 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Description
Our build-image-and-push step in the CI wasn't running. This change makes it work again :) the comparison operator for the previous step's output had to be outside the jinja placeholder clause.
How is this tested?
I changed the
on:line on the CI file and pushed the branch. This GHA run demonstrates that the build-and-push started executing, though I later canceled it.Related Tickets & Documents
Mobile & Desktop Screenshots/Recordings (if there are UI changes)