Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Datadog alert destination #6476

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Add Datadog alert destination #6476

merged 6 commits into from
Sep 28, 2023

Conversation

winebarrel
Copy link
Contributor

@winebarrel winebarrel commented Sep 24, 2023

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • New Query Runner (Data Source)
  • New Alert Destination
  • Other

Description

Add an alert destination for Datadog Events.

How is this tested?

  • Unit tests (pytest, jest)
  • E2E Tests (Cypress)
  • Manually
  • N/A

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings (if there are UI changes)

  • Config UI

  • Datadog Event Screen

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #6476 (ae1c6f6) into master (c3c54f6) will increase coverage by 0.00%.
The diff coverage is 63.63%.

@@           Coverage Diff           @@
##           master    #6476   +/-   ##
=======================================
  Coverage   61.07%   61.08%           
=======================================
  Files         157      158    +1     
  Lines       12834    12878   +44     
  Branches     1747     1753    +6     
=======================================
+ Hits         7838     7866   +28     
- Misses       4755     4766   +11     
- Partials      241      246    +5     
Files Changed Coverage Δ
redash/settings/__init__.py 98.65% <ø> (ø)
redash/destinations/datadog.py 63.63% <63.63%> (ø)

@winebarrel winebarrel marked this pull request as draft September 24, 2023 04:08
@winebarrel winebarrel marked this pull request as ready for review September 24, 2023 04:42
@justinclift
Copy link
Member

Thanks @winebarrel, this looks useful.

Someone should be around to review it in the next day or two (in theory). 😄

@justinclift justinclift added Team Review Meets PR criteria, ready for full review python Pull requests that update Python code labels Sep 24, 2023
@guidopetri guidopetri self-assigned this Sep 24, 2023
Copy link
Contributor

@guidopetri guidopetri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome PR. Thanks so much @winebarrel !

@guidopetri guidopetri merged commit 4a36abc into getredash:master Sep 28, 2023
13 checks passed
@winebarrel winebarrel deleted the support_datadog_destination branch September 28, 2023 02:03
daronstinnett pushed a commit to peachfinance/redash that referenced this pull request Dec 12, 2023
* Add Datadog alert destination

* Fix Datadog Event API response code: 200 -> 202

* Add datadog alert dest test

* Sort test_destinations.py imports

* Fix test_datadog_notify_calls_requests_post

* Fix datadog alert dest: Add aggregation_key
ofiliojo added a commit to peachfinance/redash that referenced this pull request Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code Team Review Meets PR criteria, ready for full review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants