Skip to content

Commit

Permalink
Add linux/arm64 to docker image platforms (#6525)
Browse files Browse the repository at this point in the history 
Co-authored-by: Guido Petri <[email protected]>
  • Loading branch information
@winebarrel @guidopetri
winebarrel and guidopetri authored Oct 16, 2023
1 parent 84d1693 commit d4ade51
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,7 @@ jobs:
test_all_deps=true
cache-from: type=ghq
cache-to: type=gha,mode=max
platforms: linux/amd64,linux/arm64
env:
DOCKER_CONTENT_TRUST: true

Expand Down

2 comments on commit d4ade51

@justinclift
Copy link
Member

@justinclift justinclift commented on d4ade51 Oct 17, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI step of pushing the image to docker hub is failing for us from this commit onwards:

 > [linux/arm64 frontend-builder  7/10] RUN if [ "x$skip_frontend_build" = "x" ] ; then yarn --frozen-lockfile --network-concurrency 1; fi:
1606.9 info There appears to be trouble with your network connection. Retrying...
1640.4 info There appears to be trouble with your network connection. Retrying...
1665.4 info There appears to be trouble with your network connection. Retrying...
1677.6 info There appears to be trouble with your network connection. Retrying...
1700.2 info There appears to be trouble with your network connection. Retrying...
1718.3 error An unexpected error occurred: "https://registry.yarnpkg.com/core-js/-/core-js-2.6.12.tgz: ESOCKETTIMEDOUT".
1718.3 info If you think this is a bug, please open a bug report with the information provided in "/frontend/yarn-error.log".
1718.3 info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
1736.1 info There appears to be trouble with your network connection. Retrying...
1769.7 info There appears to be trouble with your network connection. Retrying...
------
Dockerfile:22
--------------------
  20 |     ENV BABEL_ENV=${code_coverage:+test}
  21 |     
  22 | >>> RUN if [ "x$skip_frontend_build" = "x" ] ; then yarn --frozen-lockfile --network-concurrency 1; fi
  23 |     
  24 |     COPY --chown=redash client /frontend/client
--------------------
ERROR: failed to solve: process "/bin/sh -c if [ \"x$skip_frontend_build\" = \"x\" ] ; then yarn --frozen-lockfile --network-concurrency 1; fi" did not complete successfully: exit code: 1
Error: buildx failed with: ERROR: failed to solve: process "/bin/sh -c if [ \"x$skip_frontend_build\" = \"x\" ] ; then yarn --frozen-lockfile --network-concurrency 1; fi" did not complete successfully: exit code: 1

Not sure if the problem is with this commit, or if it's some other issue that's happening (eg GitHub infrastructure).

We could try backing out this specific commit and seeing if things start working again, which would probably let us know if the problem is with our source code or not.

@justinclift
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #6531 is an attempt to fix this by increasing the timeout value. Hopefully it works ok. 😄

Please sign in to comment.