Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added output for docker pull #945

Merged
merged 4 commits into from
Dec 12, 2020
Merged

Conversation

michaelroyzen
Copy link
Contributor

Resolves #892. @ivotron your feedback would be appreciated.

Copy link
Collaborator

@ivotron ivotron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a lot @michaelroyzen , this looks great. Please take a look at the feedback

src/popper/runner_host.py Outdated Show resolved Hide resolved
src/popper/runner_host.py Outdated Show resolved Hide resolved
src/popper/runner_host.py Outdated Show resolved Hide resolved
@michaelroyzen
Copy link
Contributor Author

Thanks for the feedback. I've made the changes, please let me know if there is anything else I should do.

@ivotron ivotron merged commit e3f6ad0 into getpopper:master Dec 12, 2020
@ivotron
Copy link
Collaborator

ivotron commented Dec 12, 2020

thanks a lot @michaelroyzen! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: show output of docker pull
3 participants