Distance function: multiple arguments #244
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8022781 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
brontolosone
force-pushed
the
118_variadic_distance_function
branch
from
70ba459 to
37e5528
Compare
lognaturel
reviewed
Oct 28, 2024
packages/xpath/src/evaluator/functions/FunctionImplementation.ts
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #118
One can now call distance() with multiple arguments.
I have verified this PR works in these browsers (latest versions):
What else has been done to verify that this works as intended?
yarn test-node:jsdom xformsin thepackages/xpathdirectory.Why is this the best possible solution? Were any other approaches considered?
It might not be; the argument count error handling is not ideal. When I create a form that calls
distance()(so 0 arguments) an error is thrown (good) but the message is "Argument 1 not allowed" which is rather odd. But I've been told the errors are going to get reworked, some rethinking is slated to happen in #202.Do we need any specific form for testing your changes? If so, please attach one.
The below is handy. Didn't work before, but now it does.
distance.xlsx