Support multiple columns in select widgets #2621
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #426
I realized that now as we use RecyclerView it's easy to solve this issue and give our users a new option.
What has been done to verify that this works as intended?
I used the attached form for testing and confirmed that it works as expected.
Why is this the best possible solution? Were any other approaches considered?
I'm not sure if the appearance
columns-n
I used is the best approach but it's easy to change. I was thinking aboutcompact-n
but it's already used to createGridWidgets
so it would cause conflicts.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I can't see any risk here it should be safe and shouldn't change anything else.
Do we need any specific form for testing your changes? If so, please attach one.
columns.zip
Does this change require updates to documentation? If so, please file an issue here and include the link below.
Before submitting this PR, please make sure you have:
./gradlew checkAll
and confirmed all checks still pass OR confirm CircleCI build passes and run./gradlew connectedDebugAndroidTest
locally.