Nginx server config: JS was not compressed #820
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #819
See #819 for details.
What has been done to verify that this works as intended?
Why is this the best possible solution? Were any other approaches considered?
I considered removing the
application/x-javascript
compressible type as it is severely deprecated. But who knows, perhaps some circus member proxied by nginx emits headers with that Content-Type, and in that case we'll want to compress it. It doesn't hurt to keep it around just in case.How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
Intentional changes: Faster and cheaper cold cache load.
Regression risk assessment: Low
Does this change require updates to documentation? If so, please file an issue here and include the link below.
No