Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nginx server config: JS was not compressed #820

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

brontolosone
Copy link
Contributor

@brontolosone brontolosone commented Dec 6, 2024

Closes #819

See #819 for details.

What has been done to verify that this works as intended?

  • Tested on my local docker setup. (size-1500+ bytes) JS responses get compressed now.

Why is this the best possible solution? Were any other approaches considered?

I considered removing the application/x-javascript compressible type as it is severely deprecated. But who knows, perhaps some circus member proxied by nginx emits headers with that Content-Type, and in that case we'll want to compress it. It doesn't hurt to keep it around just in case.

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Intentional changes: Faster and cheaper cold cache load.
Regression risk assessment: Low

Does this change require updates to documentation? If so, please file an issue here and include the link below.

No

@brontolosone brontolosone added the enhancement New feature or behavior label Dec 6, 2024
@brontolosone brontolosone requested a review from alxndrsn December 6, 2024 15:40
Copy link
Member

@matthew-white matthew-white left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@matthew-white matthew-white removed the request for review from alxndrsn December 6, 2024 20:38
@matthew-white matthew-white linked an issue Dec 6, 2024 that may be closed by this pull request
@brontolosone brontolosone merged commit e5e64fd into getodk:next Dec 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Content-Type application/javascript is being served uncompressed
2 participants