Feature #847: Add close button to QR popover #1104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-white
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
This is looking good. 👍 Once we complete #1084, maybe we could see if there's a different approach we could take than the data-closes-popover attribute. But I think it makes a lot of sense given how the Bootstrap plugin works.
src/components/popover.vue
Outdated
| }, | ||
| beforeUnmount() { | ||
| if (this.target != null) this.hide(); | ||
| document.removeEventListener('click', this.hideAfterClick, true); | ||
| window.removeEventListener('resize', this.hideAfterResize); | ||
| document.addEventListener('keydown', this.hideAfterEsc); |
There was a problem hiding this comment.
Suggested change
| document.addEventListener('keydown', this.hideAfterEsc); | |
| document.removeEventListener('keydown', this.hideAfterEsc); |
It seems OK to me to hide hover cards as well. We could always add that selective logic later if we need to. |
* Hide popover on click of a button that has data-closes-popover attribut * Hide popover on escape key as well
sadiqkhoja
force-pushed
the
features/847-show-close-button-for-qr-code
branch
from
8955def to
9809ae6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes getodk/central#847
Changes:
What has been done to verify that this works as intended?
Tried in chrome and added fews tests.
Why is this the best possible solution? Were any other approaches considered?
Because popover component adds click eventListener on the document that
useCapture, I was not able to handle vue events directly on qr-panel component. Having another condition incloseAfterClickthat checks if the event target is a close button, identified bydata-closes-popoverattribute, seems reasonable to me.I have also added event listener for escape key, which is applicable on all popover. If we want we can add a prop to add it on selective popovers - like maybe we don't hide hover-cards on escape 🤷♂️.
How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?
I don't see any regression risks here.
Does this change require updates to user documentation? If so, please file an issue here and include the link below.
No
Before submitting this PR, please make sure you have:
npm run testandnpm run lintand confirmed all checks still pass OR confirm CircleCI build passes