Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: file storage allow to properly handle upload error with S3 #63

Merged

Conversation

getlarge
Copy link
Owner

@getlarge getlarge commented Oct 11, 2023

Description

Fixes #62

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@getlarge getlarge added the bug Something isn't working label Oct 11, 2023
@getlarge getlarge linked an issue Oct 11, 2023 that may be closed by this pull request
1 task
@nx-cloud
Copy link

nx-cloud bot commented Oct 11, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 952b34a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 3 targets

Sent with 💌 from NxCloud.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

85.7% 85.7% Coverage
0.0% 0.0% Duplication

@getlarge getlarge merged commit 27e370f into main Oct 11, 2023
7 checks passed
@getlarge getlarge deleted the 62-fixfile-storage-allow-to-properly-handle-upload-error-with-s3 branch October 11, 2023 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix(file-storage): allow to properly handle upload error with S3
1 participant