Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make function name correct #171

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zachary-russell
Copy link

The function is described in this flow is the uniqueWords() wrapper function not wordsUsed() I changed the name to be more clear as it confused me on the first pass.

The function is described in this flow is the `uniqueWords()` wrapper function not `wordsUsed()`
@getify
Copy link
Owner

getify commented Oct 23, 2018

I understand where your confusion came from, but this change is problematic because the whole section of this chapter flows from using wordsUsed as the name to then uniqueWords. I'm not recalling why I made that shift at this point, but it seems like it was intentional.

I'm going to hold off on this change until revisiting it in second edition. If the name change is important, it should be described in the text. If it's not, then the same name should be used throughout the whole chapter.

Thanks for bringing it up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants