Fixed logo link to use home URL #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm wondering why this (minor) change have not been merged yet... Any objections out here? |
|
Ha, I actually completely forgot about this. |
|
Happily, I found it back when I was trying to resolve this empty string issue... 😉 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
base_url_relativereturns an empty string if you're not in a sub directory it seemed more reasonable to me that the logo itself would go to the main URL. Usingbase_url_relativewould cause the user to go to the same page they're at since it would be blank. So I mimicked what you're doing on the RSS link and usedhome.urlinstead.