update anchor.js and small hack to ignore some anchors #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usefull for instance to avoid duplicate anchors when anchor is used with the prettyprint plugin activated just add the css class 'hideFromAnchorJS' to the elements to ignore
…it in admin. As it updating could be done with precautions
rhukster
requested changes
Aug 22, 2017
rhukster
requested changes
Aug 31, 2017
| @@ -70,7 +70,39 @@ public function onTwigSiteVariables() | |||
| $class | |||
| $truncate | |||
| }; | |||
| // LO Hack: allow content to be hidden from the anchor | |||
There was a problem hiding this comment.
Please put this in the README.md, not in the comments in the code. Also people don't like to see the word "hack" as it has negative connotations :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update anchor.js to the 4.0.0 version
add a hack to allow content to be hidden from the anchor
usefull for instance when anchor is used with the prettyprint plugin activated
just add the css class 'hideFromAnchorJS' to the elements to hide