#1370 Handle error in a better way (#1381)

* #1370 handle error from error message Signed-off-by: NivedhaSenthil <[email protected]> * #1370 handle case without executionContextId Signed-off-by: NivedhaSenthil <[email protected]> * Bump up version 1.0.16 Signed-off-by: NivedhaSenthil <[email protected]>
getgauge · Jul 27, 2020 · 9a8dc79 · 9a8dc79
1 parent 9b22acd
commit 9a8dc79
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 14 deletions.
diff --git a/lib/handlers/runtimeHandler.js b/lib/handlers/runtimeHandler.js
@@ -57,12 +57,10 @@ const runtimeEvaluate = async (exp, executionContextId, opt = {}) => {
   try {
     runtimeResult = await runtime.evaluate(options);
   } catch (e) {
-    if (
-      e.response &&
-      e.response.message === 'Cannot find context with specified id' &&
-      executionContextId
-    ) {
-      executionContextIds = executionContextIds.filter((id) => id !== executionContextId);
+    if (e && e.message === 'Cannot find context with specified id') {
+      if (executionContextId) {
+        executionContextIds = executionContextIds.filter((id) => id !== executionContextId);
+      }
     } else {
       throw e;
     }
@@ -97,12 +95,10 @@ const runtimeCallFunctionOn = async (exp, executionContextId, opt = {}) => {
   try {
     runtimeResult = await runtime.callFunctionOn(options);
   } catch (e) {
-    if (
-      e.response &&
-      e.response.message === 'Cannot find context with specified id' &&
-      executionContextId
-    ) {
-      executionContextIds = executionContextIds.filter((id) => id !== executionContextId);
+    if (e && e.message === 'Cannot find context with specified id') {
+      if (executionContextId) {
+        executionContextIds = executionContextIds.filter((id) => id !== executionContextId);
+      }
     } else {
       throw e;
     }

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "$schema": "http://json.schemastore.org/package",
   "name": "taiko",
-  "version": "1.0.15",
+  "version": "1.0.16",
   "description": "Taiko is a Node.js library for automating Chromium based browsers",
   "main": "bin/taiko.js",
   "bin": {