Fix downloadURL usage

getgauge · May 14, 2024 · 50d2ca6 · 50d2ca6
1 parent 509799b
commit 50d2ca6
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 13 deletions.
diff --git a/lib/browser/fetcher.js b/lib/browser/fetcher.js
@@ -45,7 +45,7 @@ class BrowserFetcher {
    */
   constructor(metadata = new BrowserMetadata()) {
     this._downloadsFolder = path.join(helper.projectRoot(), '.local-chromium');
-    this.downloadURL = metadata.downloadURL();
+    this.downloadURL = metadata.downloadURL;
     this.revisionInfo = metadata.revisionInfo();
     this._platform = metadata.platform();
   }

diff --git a/lib/browser/metadata.js b/lib/browser/metadata.js
@@ -54,18 +54,10 @@ class BrowserMetadata {
     const download = browser.downloads.chrome.find(
       (download) => download.platform === this._platform,
     );
-    this.downloadEndpoint = download.url;
+    this.downloadURL = download.url;
     this.revision = browser.revision;
   }
 
-  downloadURL() {
-    return this.downloadEndpoint;
-  }
-
-  revision() {
-    return this.revision;
-  }
-
   platform() {
     return this._platform;
   }
@@ -99,8 +91,7 @@ class BrowserMetadata {
   }
 
   /**
-   * @param {string} revision
-   * @return {!BrowserFetcher.RevisionInfo}
+   * @return {!BrowserMetadata.RevisionInfo}
    */
   revisionInfo() {
     const folderPath = this._getFolderPath(this.revision);
@@ -127,7 +118,7 @@ class BrowserMetadata {
       executablePath,
       folderPath,
       local,
-      url: this.downloadEndpoint,
+      url: this.downloadURL,
     };
   }