fix: setting default "view" query params to "all" #1175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1143
Reasoning behind bug: In the code for getViewData, by default statuses only contains "open", "started" and "planned", since https://fider.io/docs/api#list-posts also uses the same function to generate the sql, the returned posts will only have "open", "started" and "planned" statuses. This conflicts with the documentations.
fider/app/services/sqlstore/postgres/common.go
Lines 33 to 37 in e55a144
Proposed changes:
Since the getViewData function is used across the app, updating statuses here might cause problems on other parts of the app, I decided to create a conditional on the route handler for the API to always set the view Query Params to "all" if it is not specified.