Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/admin order details page #2080

Closed

Conversation

Aunshon
Copy link
Collaborator

@Aunshon Aunshon commented Nov 13, 2023

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included related pull request(s) (optional)
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

image

Closes

How to test the changes in this Pull Request:

  • Order, complete order, refund, discount add coupon and see commission information and related order.

Changelog entry

Add commission information and related order information on orders and child orders.

Before Changes

Describe the issue before changes with screenshots(s).

After Changes

Describe the issue after changes with screenshot(s).

Feature Video (optional)

Link of detailed video if this PR is for a feature.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@Aunshon Aunshon added the In Progress The issues is being worked on label Nov 13, 2023
@Aunshon Aunshon self-assigned this Nov 13, 2023
@Aunshon Aunshon force-pushed the enhancement/admin-order-details-page branch from d0c6fae to 00c53ee Compare November 13, 2023 05:41
@Aunshon Aunshon added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval and removed In Progress The issues is being worked on labels Nov 15, 2023
@nurul-umbhiya nurul-umbhiya added the In Progress The issues is being worked on label Jan 19, 2024
@Aunshon
Copy link
Collaborator Author

Aunshon commented Jan 25, 2024

@nurul-umbhiya vai need to discuss this task.

@Aunshon
Copy link
Collaborator Author

Aunshon commented Feb 12, 2024

As discussed with @Mohaiminulislam1989 vai, the commission data needs to be updated, the commission data will be in the ites section not in the saperate section as commission in the screenshot. And also the pr should be synced with issue so after this issue is merged then this pr should be updated.

@Aunshon Aunshon closed this Feb 20, 2024
@Aunshon Aunshon mentioned this pull request Feb 20, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
In Progress The issues is being worked on Needs: Dev Review It requires a developer review and approval Needs: Testing This requires further testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants