Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

☎️ enhance: Backend validation of phone numbers all over the plugin #1969

Conversation

devAsadNur
Copy link
Member

@devAsadNur devAsadNur commented Aug 18, 2023

All Submissions:

  • My code follows the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

enhance: Backend validation of phone numbers all over the plugin

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@devAsadNur devAsadNur added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval labels Aug 18, 2023
@devAsadNur devAsadNur self-assigned this Aug 18, 2023
@devAsadNur devAsadNur changed the title enhance: Backend validation of phone numbers all over the plugin ☎️ enhance: Backend validation of phone numbers all over the plugin Aug 22, 2023
@nurul-umbhiya nurul-umbhiya added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Aug 28, 2023
@devAsadNur devAsadNur force-pushed the enhance/backend-validation-of-phone-numbers-all-over-the-plugin branch from 67d62da to 2fd4736 Compare August 30, 2023 04:38
@shashwatahalder01 shashwatahalder01 added QA In Progress and removed Needs: Testing This requires further testing labels Sep 22, 2023
@shashwatahalder01
Copy link
Contributor

Scenario:
phone field in Request for quotation is not validated

Screenshot:
Screenshot at Sep 22 11-17-38

@devAsadNur

This comment was marked as resolved.

@devAsadNur devAsadNur added the Needs: Testing This requires further testing label Sep 22, 2023
@shashwatahalder01 shashwatahalder01 added QA approved This PR is approved by the QA team QA In Progress and removed Needs: Testing This requires further testing QA In Progress labels Sep 22, 2023
@nurul-umbhiya nurul-umbhiya merged commit 85c496b into getdokan:develop Sep 25, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved This PR is approved by the QA team 👍 Dev Review Done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants