Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔎 feat: Admin dashboard withdraw advanced filtering with log exporting #1917

Conversation

devAsadNur
Copy link
Member

@devAsadNur devAsadNur commented Jun 15, 2023

All Submissions:

  • My code follow the WordPress' coding standards
  • My code satisfies feature requirements
  • My code is tested
  • My code passes the PHPCS tests
  • My code has proper inline documentation
  • I've included developer documentation (optional)
  • I've added proper labels to this pull request

Changes proposed in this Pull Request:

How to test the changes in this Pull Request:

Changelog entry

feat: Admin dashboard withdraws advanced filtering with CSV log exporting

Admin dashboard 'Withdraws' page has been integrated with some advanced filtering along with the log exporting feature. Now, admins can conveniently filter transactions based on the payment method and date range, enhancing their ability to analyze and manage withdrawals. Additionally, the feature to export CSV logs is also included, allowing for easy tracking and record-keeping. These integrations aim to empower the marketplace owner with comprehensive tools for efficient withdrawal management within the dashboard.

PR Self Review Checklist:

  • Code is not following code style guidelines
  • Bad naming: make sure you would understand your code if you read it a few months from now.
  • KISS: Keep it simple, Sweetie (not stupid!).
  • DRY: Don't Repeat Yourself.
  • Code that is not readable: too many nested 'if's are a bad sign.
  • Performance issues
  • Complicated constructions that need refactoring or comments: code should almost always be self-explanatory.
  • Grammar errors.

FOR PR REVIEWER ONLY:

As a reviewer, your feedback should be focused on the idea, not the person. Seek to understand, be respectful, and focus on constructive dialog.

As a contributor, your responsibility is to learn from suggestions and iterate your pull request should it be needed based on feedback. Seek to collaborate and produce the best possible contribution to the greater whole.

  • Correct — Does the change do what it’s supposed to? ie: code 100% fulfilling the requirements?
  • Secure — Would a nefarious party find some way to exploit this change? ie: everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities?
  • Readable — Will your future self be able to understand this change months down the road?
  • Elegant — Does the change fit aesthetically within the overall style and architecture?

@devAsadNur devAsadNur added the In Progress The issues is being worked on label Jun 15, 2023
@devAsadNur devAsadNur self-assigned this Jun 15, 2023
@devAsadNur devAsadNur changed the title feat: Admin dashboard withdraw advanced filtering with log exporting 🔎 feat: Admin dashboard withdraw advanced filtering with log exporting Jun 16, 2023
@devAsadNur devAsadNur added Needs: Testing This requires further testing Needs: Dev Review It requires a developer review and approval and removed In Progress The issues is being worked on labels Jul 21, 2023
},

methods: {
async getPaymentMethodSelector() {
await dokan.api.get( "/withdraw/payment_methods" )
.done( ( response, status, xhr ) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kindly handle proper error handling for all API calls.
Example:

dokan.api.get('/withdraw/payment_methods')
            .done( ( response ) => {
                   this.paymentMethods = [ { id: '', text: '' } ].concat( response.map( payment_method => {
                        return {
                            id: payment_method.id,
                            text: payment_method.title
                        }
                    } ) );
                    jQuery( '#filter-payment-methods' ).select2( {
                        data: this.paymentMethods,
                    } ).val( this.filter.payment_method ).trigger( 'change' );
            }).always( () => {
                
            }).fail( ( jqXHR ) => {
                this.paymentMethods = [ { id: '', text: '' } ].
                let message = dokan_handle_ajax_error( jqXHR );
                if ( message ) {
                    self.showErrorAlert( message );
                }
            });

@nurul-umbhiya nurul-umbhiya added 👍 Dev Review Done and removed Needs: Dev Review It requires a developer review and approval labels Aug 30, 2023
@shashwatahalder01 shashwatahalder01 removed the Needs: Testing This requires further testing label Sep 22, 2023
@shashwatahalder01 shashwatahalder01 added QA In Progress QA approved This PR is approved by the QA team and removed QA In Progress labels Sep 22, 2023
@nurul-umbhiya nurul-umbhiya merged commit e1718a5 into getdokan:develop Sep 25, 2023
1 check failed
@shashwatahalder01

This comment was marked as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
QA approved This PR is approved by the QA team 👍 Dev Review Done
Projects
None yet
3 participants