-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🔎 feat: Admin dashboard withdraw advanced filtering with log exporting #1917
Merged
nurul-umbhiya
merged 16 commits into
getdokan:develop
from
devAsadNur:feat/withdraw-advanced-filtering-with-log-exporting
Sep 25, 2023
Merged
🔎 feat: Admin dashboard withdraw advanced filtering with log exporting #1917
nurul-umbhiya
merged 16 commits into
getdokan:develop
from
devAsadNur:feat/withdraw-advanced-filtering-with-log-exporting
Sep 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne to withdraw export log
…rter API and frontend
devAsadNur
changed the title
feat: Admin dashboard withdraw advanced filtering with log exporting
🔎 feat: Admin dashboard withdraw advanced filtering with log exporting
Jun 16, 2023
devAsadNur
added
Needs: Testing
This requires further testing
Needs: Dev Review
It requires a developer review and approval
and removed
In Progress
The issues is being worked on
labels
Jul 21, 2023
nurul-umbhiya
suggested changes
Aug 18, 2023
src/admin/pages/Withdraw.vue
Outdated
}, | ||
|
||
methods: { | ||
async getPaymentMethodSelector() { | ||
await dokan.api.get( "/withdraw/payment_methods" ) | ||
.done( ( response, status, xhr ) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kindly handle proper error handling for all API calls.
Example:
dokan.api.get('/withdraw/payment_methods')
.done( ( response ) => {
this.paymentMethods = [ { id: '', text: '' } ].concat( response.map( payment_method => {
return {
id: payment_method.id,
text: payment_method.title
}
} ) );
jQuery( '#filter-payment-methods' ).select2( {
data: this.paymentMethods,
} ).val( this.filter.payment_method ).trigger( 'change' );
}).always( () => {
}).fail( ( jqXHR ) => {
this.paymentMethods = [ { id: '', text: '' } ].
let message = dokan_handle_ajax_error( jqXHR );
if ( message ) {
self.showErrorAlert( message );
}
});
nurul-umbhiya
approved these changes
Aug 30, 2023
nurul-umbhiya
added
👍 Dev Review Done
and removed
Needs: Dev Review
It requires a developer review and approval
labels
Aug 30, 2023
shashwatahalder01
added
QA In Progress
QA approved
This PR is approved by the QA team
and removed
QA In Progress
labels
Sep 22, 2023
This comment was marked as resolved.
This comment was marked as resolved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Changes proposed in this Pull Request:
How to test the changes in this Pull Request:
Changelog entry
PR Self Review Checklist:
FOR PR REVIEWER ONLY: