Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/multiple vehicles #38

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

STRML
Copy link
Collaborator

@STRML STRML commented Dec 21, 2019

Adds left and right arrows which will change vehicleIdx.

This is not very graceful; user feedback isn't immediate and could use some work. But it does persist the index between runs, so it's very useful there.

Also fixes some bugs related to tesla-api, which unnecessarily wrapped callbacks with promises when *Async methods were available, and would resolve after reject. TeslaJS also had a bug with decoding the model type that was returning Model 3 for all VINs.

Fixes #37

Screen Shot 2019-12-21 at 2 00 27 PM

*clicked rt button*, then...

Screen Shot 2019-12-21 at 2 00 35 PM

Screen Shot 2019-12-21 at 2 00 42 PM

Fixes multiple resolve-after-reject bugs and fixes vin decoding bug in 4.3.x
where all vehicles were interpreted as a Model 3
Adds left and right arrows which will change `vehicleIdx`.

This is not very graceful; user feedback isn't immediate and
could use some work. But it does persist the index between
runs, so it's very useful there.
@geraldoramos
Copy link
Owner

Thanks for taking the time doing this. I apologize for the long delay. I've not being active on this project for a while.

Are you interested in having write access to this repo?

I will review this PR soon anyway.

@STRML
Copy link
Collaborator Author

STRML commented Jan 18, 2020

That'd be great. I know how it is. I can't promise that I'll be all that active either, but I am interested in merging in the changes from Lunars as well which supports direct-to-vehicle communication (instead of just Tesla API). To do so would require an additional "add vehicle" screen with more than just the login option. That could make this quite a versatile tool.

@geraldoramos
Copy link
Owner

@STRML Done! Invite sent. Let me know when you get to a point you want me to release a new version (then auto-update will kick-in for all clients). I'm more than happy to let you do that as well but we need to handle the developer certificate stuff for mac and windows.

Feel free to merge this change you did and any others you see fit. I can launch a new release once you ask me to.

In regards to no commitment promises, I totally understand =D

@geraldoramos
Copy link
Owner

PS: I will try to setup GitHub actions to deploy the release automatically at some point...

@kevinelliott
Copy link

Can this also handle multiple cars across multiple Tesla accounts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing ability to switch between vehicles
3 participants