[FIXES #2408] SSO - Supported OpenID services #372
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current PR addresses few issues mainly related to the
refreshToken
endpoint:if ((expiresIn == null || fiveMinutesFromNow.after(expiresIn)) && refreshToken != null)
, i.e. therefreshToken
is not expired yet, thesessionToken
sent back will beNULL
resulting in an204: empty response
causing the client to lose the currentaccessToken
cache bean
of theOIDC
has a wrong name causing acontext exception
when trying to retrieve it from a newthread
accessToken
nullability but consider it valid in the case it'sempty
, and this is an error and must be threated as an error.doRefresh
method does not send theclient_id
to the IDP Refresh Endpoint, and this is can cause issues for strict compliant providers like Microsoft Azure