Skip to content

Commit

Permalink
Merge PR # 345 (Fix species classification in benchmark_categories.yml)
Browse files Browse the repository at this point in the history
This merge brings PR #345 (Fix incorrect species classification in
benchmark_categories.yml, by @yantosca) into the GCPy 1.6.0 development
stream.

Based on feedback from @ktravis213 we have made the following updates:

- Moved HACTA, HCOOH, MAP, RCOOH to Secondary_Organics:Acids
- Moved GLYC, GLYX, RCHO to Secondary_Organics:Aldehydes
- Added TLFUONE to Secondary_Organics:Other

Signed-off-by: Bob Yantosca <[email protected]>
  • Loading branch information
yantosca committed Nov 12, 2024
2 parents e212ad5 + 25eb351 commit d924dc1
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 8 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
- Fixed formatting error in `.github/workflows/stale.yml` that caused the Mark Stale Issues action not to run
- Now flag differences greater than +/- 10% in benchmark timing table outputs
- Fixed error in computation of dynamic ratio plot min & max values in `plot/six_plot.py`
- Fixed erroneous species classification in `gcpy/benchmark/modules/benchmark_categories.yml`

### Removed
- Removed `gcpy/benchmark/modules/species_database.yml` file and corresponding code pointing to this
Expand Down
18 changes: 10 additions & 8 deletions gcpy/benchmark/modules/benchmark_categories.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ FullChemBenchmark:
- HCl
- Halons
- HCFCs
- OClO
- OClO
Iodine:
Iodine:
- Iy
Expand Down Expand Up @@ -122,7 +122,7 @@ FullChemBenchmark:
- O3
- CO
- OH
- NOx
- NOx
Primary_Organics:
Alcohols:
- EOH
Expand Down Expand Up @@ -186,13 +186,20 @@ FullChemBenchmark:
Secondary_Organics:
Acids:
- ACTA
- HACTA
- HCOOH
- MAP
- RCOOH
Aldehydes:
- ACR
- ALD2
- BALD
- CH2O
- GLYC
- GLYX
- HPALDs
- MACR
- RCHO
Epoxides:
- IEPOX
Ketones:
Expand All @@ -204,13 +211,8 @@ FullChemBenchmark:
- ISOPN
Other:
- FURA
- GLYC
- GLYX
- HCOOH
- RCOOH
- MAP
- PHEN
- RCHO
- TLFUONE
Peroxides:
- ETHP
- MP
Expand Down

0 comments on commit d924dc1

Please sign in to comment.