Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use thiserror 2.0.6 #247

Merged
merged 1 commit into from
Dec 18, 2024
Merged

use thiserror 2.0.6 #247

merged 1 commit into from
Dec 18, 2024

Conversation

jayvdb
Copy link
Contributor

@jayvdb jayvdb commented Dec 12, 2024

  • I agree to follow the project's code of conduct.
  • I added an entry to CHANGES.md if knowledge of this change could be valuable to users.

Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably bump the crate version to 0.25.0

@michaelkirk
Copy link
Member

We should probably bump the crate version to 0.25.0

As a matter of process: mark any breaking change as breaking in the changelog, and we'll bump at release time. Otherwise it's harder to keep track of when someone has already bumped.

But in this case - what's the breaking change in our public api?

@jayvdb
Copy link
Contributor Author

jayvdb commented Dec 12, 2024

thiserror::Error doesnt appear in the public API according to https://docs.rs/thiserror/latest/thiserror/index.html , so this probably isnt a breaking change.

@lnicola
Copy link
Member

lnicola commented Dec 13, 2024

Yeah, the expansion output is different, but I don't think it can break any users of the crate.

@michaelkirk michaelkirk added this pull request to the merge queue Dec 18, 2024
Merged via the queue into georust:main with commit 5532d2d Dec 18, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants