Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate ChatGPT function to openai v1.0 #1368

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Migrate ChatGPT function to openai v1.0 #1368

merged 4 commits into from
Nov 17, 2023

Conversation

pchunduri6
Copy link
Contributor

@pchunduri6 pchunduri6 commented Nov 17, 2023 •
edited
Loading

Migrate ChatGPT function to openai v1.0.

The test is skipped in circleCI because we must supply the OPENAI_API_KEY. The test passes on local machine.

  • Upgrade ChatGPT function.
  • Upgrade Dall-e function.
  • Update unit test cases.
  • Verify that notebooks work correctly.

@pchunduri6 pchunduri6 linked an issue Nov 17, 2023 that may be closed by this pull request
Open AI v1.0.0 has API changes. #1353
Closed
2 tasks
@pchunduri6 pchunduri6 marked this pull request as ready for review November 17, 2023 18:16
@pchunduri6 pchunduri6 marked this pull request as draft November 17, 2023 18:27
@pchunduri6 pchunduri6 marked this pull request as ready for review November 17, 2023 21:24
@pchunduri6
Copy link
Contributor Author

@Chitti-Ankith can you check if these changes fix the OpenAI version issues you were facing?

xzdandy
xzdandy approved these changes Nov 17, 2023
View reviewed changes
Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Do we need to update the notebook?

@xzdandy xzdandy added the AI Engines Features, Bugs, related to AI Engines label Nov 17, 2023
@pchunduri6
Copy link
Contributor Author

Thanks! Do we need to update the notebook?

I manually checked the notebooks. The notebooks only use the function definitions. Since we only changed the function implementation, I did not see the need for any updates.

@pchunduri6 pchunduri6 merged commit 5aaa447 into staging Nov 17, 2023
7 checks passed
@pchunduri6 pchunduri6 deleted the openai-v1.0-upgrade branch November 17, 2023 22:46
@xzdandy xzdandy added this to the v0.3.9 milestone Nov 19, 2023
@a0x8o a0x8o mentioned this pull request Nov 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzdandy xzdandy xzdandy approved these changes

@Chitti-Ankith Chitti-Ankith Awaiting requested review from Chitti-Ankith

Assignees

@pchunduri6 pchunduri6

Labels
AI Engines Features, Bugs, related to AI Engines
Projects
EVA Public Roadmap ⚡🚀
Status: Done
Milestone
v0.3.9
Development

Successfully merging this pull request may close these issues.

Open AI v1.0.0 has API changes.
2 participants
@pchunduri6 @xzdandy