Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hackernews search in EVADB #1362

Conversation

kaushikravichandran
Copy link
Collaborator

@kaushikravichandran kaushikravichandran commented Nov 16, 2023

This PR supports searching Hackernews stories in EVADB:

  • We treat Hackernews as a data source
  • Algolia search API for hackernews is used for searching
  • Get requests are used
  • We support searching within: story, comment, URL, story, poll or a combination of them
  • Syntax:
params = {
        "query": "EVADB",
        "tags": "(story,poll)",
    }
query = f"""CREATE DATABASE hackernews_data
    WITH ENGINE = "hackernews",
    PARAMETERS = {params};"""

@kaushikravichandran kaushikravichandran marked this pull request as ready for review November 16, 2023 08:42
@kaushikravichandran kaushikravichandran added Integrations 🧩 Pull requests that update an integration AI Engines Features, Bugs, related to AI Engines labels Nov 16, 2023
@xzdandy
Copy link
Collaborator

xzdandy commented Nov 17, 2023

Thanks for adding Hackernews as data source? Could you also add a documentation page for it?
https://evadb.readthedocs.io/en/stable/source/reference/databases/index.html

@kaushikravichandran kaushikravichandran added the Data Sources Features/Bugs related to Data Sources label Nov 18, 2023
@kaushikravichandran
Copy link
Collaborator Author

Thanks for adding Hackernews as data source? Could you also add a documentation page for it? https://evadb.readthedocs.io/en/stable/source/reference/databases/index.html

Added the docs. The docs test fail now: because I have added a link to the column info of the hackernews search results table: which is in this PR, and the link will become active once the PR is merged.
Link: https://github.com/georgia-tech-db/evadb/blob/staging/evadb/third_party/databases/hackernews/table_column_info.py

Copy link
Collaborator

@xzdandy xzdandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks.

@kaushikravichandran kaushikravichandran merged commit aab2446 into georgia-tech-db:staging Nov 20, 2023
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Engines Features, Bugs, related to AI Engines Data Sources Features/Bugs related to Data Sources Integrations 🧩 Pull requests that update an integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants