-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Weaviate integration #1360
Add Weaviate integration #1360
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👋 Hello @hunteritself, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify that your PR is up-to-date with
georgia-tech-db/eva
master
branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pull
andgit merge master
locally. - ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
- ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.
Could you fix the merge conflicts? Thanks! |
Nice PR! Can we also add support for label-based filtering? -- https://weaviate.io/developers/weaviate/search/filters. Like searching only among a subset of documents that satisfy some label value (e.g., label = 'cs450'). We can discuss more via Slack. |
Sure Professor. I'll add this "label-based filtering" feature soon. |
…staging Merging changes from upstream to include recent updates.
Hi @hunteritself, could you add a test case and documentation please?
|
You can fix the linter by running |
Hi Andy, I have fixed all the code formatting errors suggested. The local test |
Add Weaviate integration, features include: