Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Weaviate integration #1360

Merged
merged 17 commits into from
Nov 21, 2023
Merged

Conversation

hunteritself
Copy link
Contributor

Add Weaviate integration, features include:

  1. Initiate the required environment and connect to Weaviate vector database;
  2. Create a class;
  3. Delete a class;
  4. Add data;
  5. Make similarity-based queries.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hello @hunteritself, thanks for submitting a EVA DB PR 🙏 To allow your work to be integrated as seamlessly as possible, we advise you to:

  • ✅ Verify that your PR is up-to-date with georgia-tech-db/eva master branch. If your PR is behind you can update your code by clicking the 'Update branch' button or by running git pull and git merge master locally.
  • ✅ Verify that all EVA DB Continuous Integration (CI) checks are passing.
  • ✅ Reduce changes to the absolute minimum required for your bug fix or feature addition.

@xzdandy
Copy link
Collaborator

xzdandy commented Nov 16, 2023

Could you fix the merge conflicts? Thanks!

@jarulraj
Copy link
Member

Nice PR! Can we also add support for label-based filtering? -- https://weaviate.io/developers/weaviate/search/filters. Like searching only among a subset of documents that satisfy some label value (e.g., label = 'cs450'). We can discuss more via Slack.

@hunteritself
Copy link
Contributor Author

Sure Professor. I'll add this "label-based filtering" feature soon.

@xzdandy
Copy link
Collaborator

xzdandy commented Nov 19, 2023

Hi @hunteritself, could you add a test case and documentation please?

@xzdandy xzdandy added the Data Sources Features/Bugs related to Data Sources label Nov 19, 2023
@xzdandy xzdandy added this to the V0.3.10 milestone Nov 19, 2023
@xzdandy
Copy link
Collaborator

xzdandy commented Nov 20, 2023

You can fix the linter by running bash script/test/test.sh -m LINTER

@hunteritself
Copy link
Contributor Author

Hi Andy,

I have fixed all the code formatting errors suggested. The local test bash script/test/test.sh -m LINTER has passed. But the CircleCI test on GitHub still failed, showing test/integration_tests/long/test_similarity.py has incorrect formatting. Could you please help take a look? Thank you.

@xzdandy xzdandy merged commit 0268df2 into georgia-tech-db:staging Nov 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Sources Features/Bugs related to Data Sources
Projects
Development

Successfully merging this pull request may close these issues.

3 participants