Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored sqlalchemy-related parsing of geometry #88

Conversation

ricardogsilva
Copy link
Member

@ricardogsilva ricardogsilva commented Dec 21, 2023

This PR refactors parsing of geometries done in the sqlalchemy backend in order to recognize custom CRS definitions.

Further discussion in #66

Included also a couple of tests which should clarify the result of the proposed modification.

@francbartoli
Copy link

Failing test would be fixed after the merge of #87

@tomkralidis
Copy link
Member

@ricardogsilva can you rebase (will also trigger CI)? Thanks.

@ricardogsilva ricardogsilva force-pushed the 66-is-pygeofilter-supporting-various-crs branch from 5bf7f65 to 5414c88 Compare January 8, 2024 13:46
@ricardogsilva
Copy link
Member Author

@tomkralidis done

@tomkralidis tomkralidis merged commit 296e8b9 into geopython:main Jan 8, 2024
3 checks passed
@Alex-NRCan
Copy link

Alex-NRCan commented May 9, 2024

Thank you for pulling this code in 👍

If I may ask, as this fix was pulled a few months ago, is there an intention to create, in the near future, a new release of pygeofilter? I'm asking, because it'd be great if pygeoapi could, natively, when doing its pip install, benefit from the changes to the parse_geometry function fixed herein. Otherwise, at the moment, here at Natural Resources Canada, I have to maintain a copy of a modified pygeofilter code for our pygeoapi usage and when we deploy.

@francbartoli
Copy link

I hope so @Alex-NRCan, if I may suggest you could install pygeofilter from the master branch as a workaround. With or without a docker image

@Alex-NRCan
Copy link

Alex-NRCan commented Aug 13, 2024

For the purpose of follow-up.
The release 0.2.4 of July 10th includes the aforementioned fix now and therefore pygeoapi can install itself with a fixed version of pygeofilter hence automatically supporting CQL queries with different crs better. No need (at least for our usecase and my tests) to work with a distinct clone of pygeofilter anymore. Yay! 👍
Seems fully resolved, for pygeoapi usage, as of July 10th 2024. Best regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is Pygeofilter supporting various CRS other than 4326?
4 participants