Use build number in android + desktop

geoff-powell · Jan 11, 2024 · 2a0b5a8 · 2a0b5a8
1 parent a57e91a
commit 2a0b5a8
Show file tree

Hide file tree

Showing 6 changed files with 19 additions and 11 deletions.
diff --git a/.github/workflows/android.yml b/.github/workflows/android.yml
@@ -33,7 +33,7 @@ jobs:
         gradle-home-cache-cleanup: true
 
     - name: Build with Gradle
-      run: ./gradlew composeApp:assembleDebug
+      run: ./gradlew composeApp:assembleDebug -Pbuild-numeber=${{ needs.build-number.outputs.build-number }}
 
   build-release:
     runs-on: ubuntu-latest
@@ -51,7 +51,7 @@ jobs:
         run: chmod +x gradlew
 
       - name: Build with Gradle
-        run: ./gradlew composeApp:assembleRelease
+        run: ./gradlew composeApp:assembleRelease -Pbuild-numeber=${{ needs.build-number.outputs.build-number }}
 
   test:
     runs-on: ubuntu-latest

diff --git a/.github/workflows/build-number.yml b/.github/workflows/build-number.yml
@@ -23,7 +23,7 @@ jobs:
     permissions:
       contents: write
     outputs:
-      build_number: ${{ steps.build-number.outputs.BUILD_NUMBER }}
+      build-number: ${{ steps.build-number.outputs.BUILD_NUMBER }}
     steps:
     - uses: actions/checkout@v4
       with:

diff --git a/.github/workflows/ios.yml b/.github/workflows/ios.yml
@@ -4,7 +4,6 @@ on:
   push: 
     branches: 
       - main
-      - ci-version-code # TODO: this is a temporary branch for testing (REMOVE)
   pull_request:
 
 concurrency:

diff --git a/build.gradle.kts b/build.gradle.kts
@@ -1,4 +1,9 @@
-import org.jetbrains.compose.ComposeExtension
+// Manifest version information!
+val versionMajor = 1
+val versionMinor = 0
+val versionPatch = 0
+val versionBuild = providers.gradleProperty("build-number").orElse("0").map { it.toInt() }
+val versionName = "$versionMajor.$versionMinor.$versionPatch"
 
 group = "com.greenmiststudios"
 version = "1.0-SNAPSHOT"
@@ -24,6 +29,9 @@ plugins {
 }
 
 allprojects {
+  ext.set("version", versionName)
+  ext.set("versionBuild", versionBuild)
+
   extensions.findByType<com.diffplug.gradle.spotless.SpotlessExtension>()?.apply { // if you are using build.gradle.kts, instead of 'spotless {' use:
     kotlin {
       // by default the target is every '.kt' and '.kts` file in the java sourcesets

diff --git a/composeApp/build.gradle.kts b/composeApp/build.gradle.kts
@@ -9,6 +9,8 @@ plugins {
   alias(libs.plugins.spotless)
 }
 
+val projectVersion = project.ext.get("version")?.toString()
+
 kotlin {
   js(IR) {
     browser {
@@ -82,8 +84,8 @@ android {
     applicationId = "com.greenmiststudios.tidy"
     minSdk = libs.versions.android.minSdk.get().toInt()
     targetSdk = libs.versions.android.targetSdk.get().toInt()
-    versionCode = project.properties["tidy.version_code"]?.toString()?.toInt() ?: 1
-    versionName = project.properties["tidy.version_name"]?.toString()
+    versionCode = project.ext.get("versionBuild")?.toString()?.toInt() ?: 0
+    versionName = projectVersion
   }
   packaging {
     resources {
@@ -114,7 +116,7 @@ compose.desktop {
     nativeDistributions {
       targetFormats(TargetFormat.Dmg, TargetFormat.Msi, TargetFormat.Deb)
       packageName = "com.greenmiststudios.tidy"
-      packageVersion = project.properties["tidy.version_name"]?.toString()
+      packageVersion = projectVersion
     }
   }
 }

diff --git a/scripts/build-number.sh b/scripts/build-number.sh
@@ -1,6 +1,4 @@
 #!/bin/bash
-set -x
-
 TAGS=$(git show-ref --tags)
 
 function getBuildNumberTag {
@@ -42,4 +40,5 @@ else
   echo "Skipping tag creation."
 fi
 
-echo "BUILD_NUMBER=$CURRENT_BUILD_NUMBER" >> "$GITHUB_ENV"
+echo "BUILD_NUMBER=$CURRENT_BUILD_NUMBER" >> "$GITHUB_ENV"
+echo "BUILD_NUMBER=$CURRENT_BUILD_NUMBER" >> "$GITHUB_OUTPUT"