Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tag patterns #94

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Robinlovelace
Copy link
Contributor

No description provided.

@Robinlovelace
Copy link
Contributor Author

Hey @Nowosad and @jannes-m please could you take a look at the example above? I think we can now change all image types like this:

- ghcr.io/geocompx/docker:image_tag
+ ghcr.io/geocompx/image:tag

I lack time this week though, any help with this welcome, it's quite a big change so would like a couple of extra pairs of eyes on it if possible 🙏

@Robinlovelace Robinlovelace changed the title Change take for minimal example, starter on #88 Update tag patterns Oct 14, 2024
@jannes-m
Copy link
Contributor

I think you are right and that this change is overdue. The docker part in the image did not add much and we never had a version tag.
If we do that, we should also think about images releases that would then be used as tags. And we would have to change our documentation. At the top of my head I remember: gis chapter in our book and the basic qgisprocess vignette.

@Robinlovelace
Copy link
Contributor Author

Thanks @jannes-m, this PR is designed to contain those updates to the docs you mention. If you could have a look at the readme and test out the new tags, particularly for the qgis image, that would be greatly appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change image paths from ghcr.io/geocompx/docker:image to ghcr.io/geocompx/image?
2 participants