Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt code to ol 9.0.0 #9

Merged
merged 4 commits into from
Mar 15, 2024
Merged

Adapt code to ol 9.0.0 #9

merged 4 commits into from
Mar 15, 2024

Conversation

fredj
Copy link
Contributor

@fredj fredj commented Mar 13, 2024

This breaks compatibility with ol < 9

@ger-benjamin
Copy link
Member

What that means for libraries using ol < 9 ?
Should we have two differents release for a while ? one for ol <9, and one for ol >=9 ?

I currently can't migrate to ol 9. Thats a good question for every Geoblocks.

@fredj
Copy link
Contributor Author

fredj commented Mar 13, 2024

I didn't looked into it but I don't think we can make this change backward compatible for ol < 9.

Easiest solution is to create a new major release with only ol >= 9 as peerDependencies.
Users of this lib with ol < 9 are using the previous release

@gberaudo gberaudo merged commit 94d543f into master Mar 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants