Add wms image raw implementation #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismailsunni
approved these changes
Feb 13, 2024
ger-benjamin
force-pushed
the
add_wms_image_raw_implementation
branch
from
92bf35f to
e541fc3
Compare
gberaudo
reviewed
Feb 13, 2024
ger-benjamin
force-pushed
the
add_wms_image_raw_implementation
branch
5 times, most recently
from
c0462da to
9a2da79
Compare
ger-benjamin
force-pushed
the
add_wms_image_raw_implementation
branch
from
9a2da79 to
c7a0d38
Compare
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired (or more) by https://github.com/camptocamp/ngeo/blob/master/src/print/Service.js#L248
That's probably not very generic (maybe not working), but at least you probably only have to redefine
encodeWmsLayerStateto have your layer.I think we can also better use the (unused) customizer,.
It will be improved by testing it on a real project.