Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements #1

Merged
merged 15 commits into from
Feb 4, 2021
Merged

Improvements #1

merged 15 commits into from
Feb 4, 2021

Conversation

gberaudo
Copy link
Contributor

No description provided.

@gberaudo gberaudo requested a review from fredj January 26, 2021 21:10
.eslintrc.yml Outdated Show resolved Hide resolved
src/router/OSRMRouter.js Outdated Show resolved Hide resolved
src/router/OSRMRouter.js Outdated Show resolved Hide resolved
@fredj
Copy link
Contributor

fredj commented Jan 29, 2021

I've found a small issue with the delete interaction (click with alt key): an exception is raised when the segment is clicked instead of a control point. Patch to come

@gberaudo
Copy link
Contributor Author

@fredj, I have fixed #2.

@fredj
Copy link
Contributor

fredj commented Jan 29, 2021

thinking again about the profile; what's the reason to store it at all ? can't we use the geometry instead ? (add elevation to the existing coordinates)

@gberaudo
Copy link
Contributor Author

thinking again about the profile; what's the reason to store it at all ? can't we use the geometry instead ? (add elevation to the existing coordinates)

The profile is used with straight lines, which only have 2 coordinates.

@gberaudo gberaudo merged commit 031ac9e into master Feb 4, 2021
@gberaudo gberaudo deleted the improvements branch February 4, 2021 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants