Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added XGBoost tutorial #7

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Added XGBoost tutorial #7

merged 2 commits into from
Aug 14, 2024

Conversation

savalann
Copy link
Member

@savalann savalann commented Aug 12, 2024

Hi

I pushed the scripts and files for the Tutorial: ML for Hydrological Sciences.

(uwhackweek/schedule-2024#40)

Best,
Savalan

@scottyhq scottyhq added the preview Create a website PR preview label Aug 12, 2024
Copy link

@scottyhq
Copy link
Contributor

Thanks @savalann for putting this together! Just had a quick look and a couple suggestions:

  1. You'll need to add your notebooks to the table of contents file if you want them to render on the website

  2. This is currently 60MB, which is kind of large!

  3. This seems to be a lot of content for a 60min session, so be sure to do a run-though to make sure you're able to cover your main points in the allotted time

@scottyhq scottyhq requested a review from spestana August 14, 2024 13:39
Copy link
Contributor

@spestana spestana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this great contribution @savalann ! I've noted a couple of requested changes for typos.

"metadata": {},
"outputs": [],
"source": [
"!pip install hydroeval xgboost"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested this on CryoCloud yet? If possible, we'd like to make sure any packages needed are pre-installed with the default environment participants will use during the hackweek. Though, I was able to run this pip install command successfully, so perhaps we don't need to pre-install these.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Steven
Thank you for the corrections. I tried it on the CryoCloud, which worked with the first pip installs.
Do you think you need to pre-install them?
Have you run all the code?

Copy link
Member

@weiji14 weiji14 Aug 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add in py-xgboost and hydroeval to CryoCloud in CryoInTheCloud/hub-image#125 if you want? Just checking if you need the GPU version of XGBoost, or just the CPU version.

},
"source": [
"#### 4.2. Load Dataset\n",
"- Using the boto3 libarary we get the input dataset from the CIROH S3 bucket."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"- Using the boto3 libarary we get the input dataset from the CIROH S3 bucket."
"- Using the boto3 library we get the input dataset from the CIROH S3 bucket."

},
"source": [
"#### 4.2. Load Dataset\n",
"- Using the boto3 libarary we get the input dataset from the CIROH S3 bucket."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"- Using the boto3 libarary we get the input dataset from the CIROH S3 bucket."
"- Using the boto3 library we get the input dataset from the CIROH S3 bucket."

@spestana
Copy link
Contributor

@savalann I am going to go ahead and merge this pull request, then I will make some of the above requested changes myself :)

Thanks again!

@spestana spestana merged commit 334778e into geo-smart:main Aug 14, 2024
6 checks passed
@spestana
Copy link
Contributor

@savalann I am going to go ahead and merge this pull request, then I will make some of the above requested changes myself :)

Thanks again!

I've made those changes, see PR #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview Create a website PR preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants