chore: removed empty string and added throws

gentlementlegen · May 20, 2024 · eb6c3a3 · eb6c3a3
1 parent 8fe5405
commit eb6c3a3
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/github/handlers/index.ts b/src/github/handlers/index.ts
@@ -84,7 +84,7 @@ async function handleEvent(event: EmitterWebhookEvent, eventHandler: InstanceTyp
       inputs: new Array(pluginChain.uses.length),
     };
 
-    const ref = isGithubPluginObject ? plugin.ref ?? (await getDefaultBranch(context, plugin.owner, plugin.repo)) : "";
+    const ref = isGithubPluginObject ? plugin.ref ?? (await getDefaultBranch(context, plugin.owner, plugin.repo)) : plugin;
     const token = await eventHandler.getToken(event.payload.installation.id);
     const inputs = new DelegatedComputeInputs(stateId, context.key, event.payload, settings, token, ref);
 

diff --git a/src/github/handlers/repository-dispatch.ts b/src/github/handlers/repository-dispatch.ts
@@ -35,8 +35,7 @@ export async function repositoryDispatch(context: GitHubContext<"repository_disp
 
   const currentPlugin = state.pluginChain[state.currentPlugin];
   if (!isGithubPlugin(currentPlugin.plugin)) {
-    console.error("Trying to call a non-github plugin.");
-    return;
+    throw new Error("Trying to call a non-github plugin.");
   }
   if (currentPlugin.plugin.owner !== context.payload.repository.owner.login || currentPlugin.plugin.repo !== context.payload.repository.name) {
     console.error("Plugin chain state does not match payload");
@@ -52,8 +51,7 @@ export async function repositoryDispatch(context: GitHubContext<"repository_disp
     return;
   }
   if (!isGithubPlugin(nextPlugin.plugin)) {
-    console.error("Trying to call a non-github plugin.");
-    return;
+    throw new Error("Trying to call a non-github plugin.");
   }
   console.log("Dispatching next plugin", nextPlugin);