Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/fix-isort #15

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Feature/fix-isort #15

merged 2 commits into from
Jul 8, 2024

Conversation

rjchallis
Copy link

@rjchallis rjchallis commented Jul 8, 2024

Summary by Sourcery

This pull request enhances the codebase by adding isort configuration to setup.cfg, ensuring consistent import sorting that aligns with the Black code style.

  • Enhancements:
    • Configured isort settings in setup.cfg to align with the Black code style, including multi-line output, trailing commas, grid wrap, and line length.

Copy link

sourcery-ai bot commented Jul 8, 2024

Reviewer's Guide by Sourcery

This pull request adds a new isort configuration to the setup.cfg file. The changes include setting multi_line_output to 3, enabling trailing commas, setting force_grid_wrap to 0, configuring the line length to 88, and using the black profile. These changes ensure that the import sorting aligns with the black code formatter settings.

File-Level Changes

Files Changes
setup.cfg Added isort configuration to align with black formatting.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rjchallis - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 1 issue found
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@@ -4,6 +4,13 @@ universal=1
[metadata]
description-file=README.md

[isort]
multi_line_output = 3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: Consider using a more descriptive value for multi_line_output.

The value '3' for multi_line_output is not immediately clear. Consider using a more descriptive value or adding a comment to explain its purpose.

Suggested change
multi_line_output = 3
# multi_line_output = 3 corresponds to Vertical Hanging Indent style
multi_line_output = 3

@rjchallis rjchallis merged commit 5a423b8 into master Jul 8, 2024
2 checks passed
@rjchallis rjchallis deleted the feature/fix-isort branch July 8, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant