Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/run-workflow-on-pr-to-master #12

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

rjchallis
Copy link

@rjchallis rjchallis commented Jun 26, 2024

Summary by Sourcery

This pull request updates the CI workflows to ensure they run on pull requests targeting the 'master' branch, in addition to the existing 'main' branch.

  • CI:
    • Updated CI workflows to run on pull requests targeting the 'master' branch in addition to the 'main' branch.

Copy link

sourcery-ai bot commented Jun 26, 2024

Reviewer's Guide by Sourcery

This pull request updates the GitHub Actions workflows to include the 'master' branch in the list of branches that trigger the workflows on pull requests. Specifically, the 'flake8' and 'sourcery' workflows are modified to run on pull requests targeting the 'master' branch in addition to the 'main' branch.

File-Level Changes

Files Changes
.github/workflows/flake8.yml
.github/workflows/sourcery.yml
Added 'master' branch to the list of branches that trigger the respective workflows on pull requests.

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rjchallis - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@rjchallis rjchallis merged commit 985748b into master Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant