Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rdf_uri_prefix for PMID and GO_REF #2370

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Add rdf_uri_prefix for PMID and GO_REF #2370

merged 1 commit into from
Oct 8, 2024

Conversation

pkalita-lbl
Copy link
Contributor

Related to geneontology/gocam-py#13

These changes add a rdf_uri_prefix field for PubMed and GO_REF databases. This is with an eye toward having them included in the go context of prefixmaps.

@pkalita-lbl pkalita-lbl requested a review from kltm October 7, 2024 19:23
kltm
kltm approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@kltm kltm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me.
I think this is fine to merge on your timing, but I'd also just like to make sure this is on @balhoff 's radar.

@balhoff
Copy link
Member

balhoff commented Oct 8, 2024

Good as far as I know!

@pkalita-lbl pkalita-lbl merged commit 7869016 into master Oct 8, 2024
2 checks passed
@pkalita-lbl pkalita-lbl deleted the additional-rdf-uri-prefixes branch October 8, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kltm kltm kltm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pkalita-lbl @balhoff @kltm