Translate filter on Select2 placeholder #388
Conversation
Simple way to add a translate twig filter when using a placeholder on a select2.
|
Any opinion from the maintainer(s) ? |
| @@ -656,6 +656,10 @@ | |||
| <script type="text/javascript"> | |||
| jQuery(document).ready(function($) { | |||
| $field = $('#{{ id }}'); | |||
|
|
|||
| {% if configs.placeholder is defined %} | |||
| {% set configs = {'placeholder': configs.placeholder|trans} + configs %} | |||
There was a problem hiding this comment.
{% set configs.placeholder = configs.placeholder|trans %}would be better optmized.
Also a possibility to fetch the translation domain from the form config itself
There was a problem hiding this comment.
Neirda24, your code doesn't work.
Unexpected token "punctuation" of value "." ("end of statement block" expected) in GenemuFormBundle:Form:jquery_layout.html.twig at line 661.
The original method by jcrombez work well
{% set configs = {'placeholder': configs.placeholder|trans} + configs %}
but i prefer this
{% set configs = configs|merge({"placeholder": configs.placeholder|trans}) %}
| @@ -656,6 +656,10 @@ | |||
| <script type="text/javascript"> | |||
| jQuery(document).ready(function($) { | |||
| $field = $('#{{ id }}'); | |||
|
|
|||
| {% if configs.placeholder is defined %} | |||
| {% set configs = {'placeholder': configs.placeholder|trans} + configs %} | |||
There was a problem hiding this comment.
Neirda24, your code doesn't work.
Unexpected token "punctuation" of value "." ("end of statement block" expected) in GenemuFormBundle:Form:jquery_layout.html.twig at line 661.
The original method by jcrombez work well
{% set configs = {'placeholder': configs.placeholder|trans} + configs %}
but i prefer this
{% set configs = configs|merge({"placeholder": configs.placeholder|trans}) %}
Simple way to add a translate twig filter when using a placeholder on a select2.